Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configs for LumenPnP #766

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Update configs for LumenPnP #766

merged 3 commits into from
Jun 29, 2022

Conversation

theacodes
Copy link
Contributor

Description

Benefits

  • Configuration file names now match the company and product nae.
  • Higher microstepping resolution allows for more accurate calibration and placement.

Related Issues

Closes opulo-inc/lumenpnp#584

@theacodes
Update configs for LumenPnP
1f84fdc 
* Renames the files from `Index/REV_03` to `Opulo/Lumen_REV3`, since the company & machine have been renamed for legal reasons.
* Changes microstepping resolution to `256` as per opulo-inc/lumenpnp#584.
@thisiskeithb
Copy link
Member

thisiskeithb commented Jun 27, 2022 •
edited
Loading

Since you're using TMC2209s and have INTERPOLATE set to true in this config, microsteps are already interpolated to 256.

You'd probably achieve the same level precision if you double or quadruple your standard steps/mm & microsteps instead of potentially overloading the MCU with raw microstepping set to 256.

@theacodes
Copy link
Contributor Author

The CPU isn't haven't any issue keeping up with our steps/s, since the Lumen is a relatively slow machine.

@thinkyhead thinkyhead merged commit acf9031 into MarlinFirmware:import-2.1.x Jun 29, 2022
thinkyhead pushed a commit that referenced this pull request Jun 30, 2022
@theacodes @thinkyhead
📝 Index Rev03 => LumenPnP (#766)
75bcbaa
@thisiskeithb thisiskeithb mentioned this pull request Jun 30, 2022
Closed
@thisiskeithb
Copy link
Member

thisiskeithb commented Jun 30, 2022 •
edited
Loading

@theacodes: Just to confirm, this is the "LumenPnP" by "Opulo" with a motherboard named "REV3"? We need to rename code/tests upstream in the main Marlin repo and I want to make sure this is named properly.

Edit:

This was referenced Jun 30, 2022
Merged
Closed
Closed
@theacodes
Copy link
Contributor Author

theacodes commented Jun 30, 2022 via email

@thisiskeithb
Copy link
Member

@theacodes Since you replied via email you probably didn't see my edit: #766 (comment)

@theacodes
Copy link
Contributor Author

Got it. Yes, that's fine. It can be referred to as the "Lumen REV3" or just "REV3", we'll have a REV4 that's quite a bit different eventually.

thinkyhead added a commit that referenced this pull request Jul 1, 2022
@thinkyhead
📝 Index Rev03 => LumenPnP (#766)
57cd85a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
config updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Marlin configuration with higher-resolution microstepping
3 participants
@theacodes @thisiskeithb @thinkyhead